Reply To: Light weight screenshot and annotate combo

Forum › Forums › antiX-development › Graphics › Light weight screenshot and annotate combo › Reply To: Light weight screenshot and annotate combo

#62166
BobC
Moderator

    Skidoo, Thanks for testing. I can tell you tested from a blank sheet of paper, which is good, because the program is old with many new features cobbled on. That had advantages that much of the translation was done, and that the basic functions already existed and worked acceptably to many. I did try to avoid changing things as much as possible in those areas of the code while still providing the improvements I and others needed, but there is some possibility of me breaking the original code, especially given the language involved not being one I’m a pro with.

    “Region to Capture” –} “Window”
    did not behave as expected. Expected: allow me to choose which program window.
    S’Okay, just consider labeling it “Foreground Window”

    No, I really think this qualifies as a bug.
    When I click a window which is NOT currently top-of-stack,
    the screencap reflects the GEOMETRY of the clicked window, but it is partially obscured by the other windows in the stack.
    What’s missing is a “bring to front” operation prior to performing the capture.

    The way the window code works is determined by Scrot. The code used is the same as the existing antiX screenshot in that respect. I can’t fix that easily because the window selection is being done in scrot itself. The possible options we could take to improve it would be to
    1. Add a tooltip that tells the user they need to make sure the window is in full view before clicking Ok
    2. or Add a popup in window mode that tells the user they need to make sure the window they want is in full view before clicking Ok
    3. or Add a popup maybe with wmctrl to select the window that then brings it to front and in focus so scrot can then take a screenshot of the window in focus. This could be a future “to do”, as it would likely be a bunch more work.

    “include mouse cursor in picture”
    This is ineffective when Full Screen has been selected.
    Suggestion:

    if Window:
       [ ] include window border
       [ ] include mouse cursor in picture

    I’m not sure if include mouse pointer will work in full screen or not. I can try it. If it doesn’t cause a crash I will include it.
    I could add an action to change the default mouse cursor to include it in window mode, but if someone wanted not to have it they would need to reselect the value each time. That violates my “I will save your settings” directive.
    I would rather let the user decide if they want the border or not because it doesn’t work right with it enabled with some desktop setups. (pointed out by ile)

    name to save set to “screenshota.jpg
    [✓] choose a differenct directory (FWIW, I chose /tmp)
    result: popup stating “File extension $EXT was changed. Please try again.”
    ^—— I am unable to CONSISTENTLY reproduce this bug.
    Unsure which exact setting(s) triggers it.
    Am certain that I had not touched the “File Type” selectbox.

    I really didn’t understand that code but left it the way it was. It looked like the intent was to popup a select so you could choose a different directory, but somehow it allows the user to select a file, and that file might have a different extension. I wonder why it cares? I don’t think it should allow you to change the file name or extension, just choose a directory, but that doesn’t seem to be the way it works.

    .
    “add text entered below”
    ^— him needs to escape, or validate, the user-supplied string.
    As is, entering “hi mom” (with quotes) is inexplicably discarded and the generic “Screenshot” red text is overlaid instead. Same (discard) occurs if the string contains a backtick character or…

    If I knew all of the special characters that aren’t allowed, I could figure out how to filter them out. Another option would be to change the label to “Add text entered below (do not use special characters)”

    .

    “add Date:Time to note text”
    ^—- naw. Show human-friendly localized formatting here, not underscore-separated n_umb_er_s

    Ok, I suppose. I will change it to your way. It was a toss-up. I decided to put the date on the pic in format similar to the naming of the file.

    “Capture Quality”
    I have never (yet) touched the FileType nor CaptureQuality controls.
    Although the default “jpg” is selected, confusingly the CaptureQuality default is 80
    and text reads “something something for png files use 80 something”

    Hmm, maybe the text just begs clarification “for png files use ONLY 70, 80 or 90”

    I have never used it other than to test if it causes a crash. I will change it to use your wording. I have no knowledge on it.
    .

    • This reply was modified 5 years, 3 months ago by BobC.

    Here is the link to SEARCH THE FORUM >> http://www.antixforum.com/search-forums